Fix retro-compatibility with 222 and 221 #339
Merged
+69
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 82.72% 82.66% -0.06%
==========================================
Files 35 35
Lines 3184 3173 -11
==========================================
- Hits 2634 2623 -11
Misses 550 550 |
…equired server version to 5
PProfizi
changed the title
cbellot000
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ANSYS_VERSION input in retro tests in ci.yml and ci_release.yml was set to env.ANSYS_VERSION instead of matrix.ANSYS_VERSION, meaning retro tests actually ran on the latest server.
Once this is rectified, it appears that operator
extract_scopingis too recent to be used.It is in the code at:
_get_resultfor each Simulation variant -> Actually unused, remove useless code inHarmonicMechanicalSimulation,ModalMechanicalSimulationandTransientMechanicalSimulationMeshIndex._evaluate_valuesin caseself._scoping_ref is None-> implement a retro-compatible (slower) version when DPF<5.0